feat(deno): add hapi integration#22462
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 19:40
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 21, 2026 19:49
6b79404 to
519f13a
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 21, 2026 19:49
6237ccf to
4c157ad
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 21, 2026 21:43
519f13a to
4298281
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 21, 2026 21:43
4c157ad to
86ed574
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 22, 2026 00:51
4298281 to
37ffb67
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 22, 2026 00:51
86ed574 to
55f7640
Compare
nicohrubec
approved these changes
Jul 22, 2026
JPeer264
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-hapi
branch
from
July 22, 2026 14:42
37ffb67 to
0460096
Compare
isaacs
requested review from
chargome,
msonnb and
mydea
and removed request for
a team
July 22, 2026 14:42
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-express
branch
from
July 22, 2026 14:42
55f7640 to
8d4883f
Compare
andreiborza
approved these changes
Jul 22, 2026
Comment on lines
+18
to
+55
| /** See deno-redis.test.ts — same sink shape, deduped for clarity. */ | ||
| function transactionSink(): { | ||
| beforeSendTransaction: (event: TransactionEvent) => null; | ||
| waitFor: (predicate: (event: TransactionEvent) => boolean) => Promise<TransactionEvent>; | ||
| } { | ||
| const transactions: TransactionEvent[] = []; | ||
| const waiters: { predicate: (e: TransactionEvent) => boolean; resolve: (e: TransactionEvent) => void }[] = []; | ||
| return { | ||
| beforeSendTransaction(event) { | ||
| transactions.push(event); | ||
| for (let i = waiters.length - 1; i >= 0; i--) { | ||
| const w = waiters[i]!; | ||
| if (w.predicate(event)) { | ||
| waiters.splice(i, 1); | ||
| w.resolve(event); | ||
| } | ||
| } | ||
| return null; | ||
| }, | ||
| waitFor(predicate) { | ||
| const already = transactions.find(predicate); | ||
| if (already) return Promise.resolve(already); | ||
| return new Promise<TransactionEvent>(resolve => { | ||
| waiters.push({ predicate, resolve }); | ||
| }); | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> { | ||
| let timer: ReturnType<typeof setTimeout> | undefined; | ||
| const timeout = new Promise<T>((_, reject) => { | ||
| timer = setTimeout(() => reject(new Error(`Timed out waiting for ${what} after ${ms}ms`)), ms); | ||
| }); | ||
| return Promise.race([p, timeout]).finally(() => { | ||
| if (timer !== undefined) clearTimeout(timer); | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
q: Are these useful for other integrations? Maybe we can extract them into test helpers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.